From: Thomas Fitzsimmons Date: Thu, 13 Nov 2014 07:43:36 +0000 (-0500) Subject: Handle nil password-cache in ldap-password-read X-Git-Tag: emacs-25.0.90~2582^2~2^2~3 X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=9006ccd6c2c0a530b0ec0a341dcaebc8cc70d5f5;p=emacs.git Handle nil password-cache in ldap-password-read * net/ldap.el (ldap-password-read): Handle password-cache being nil. --- diff --git a/lisp/ChangeLog b/lisp/ChangeLog index d395f2e3af6..9748fe1fd19 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,8 @@ +2014-11-13 Thomas Fitzsimmons + + * net/ldap.el (ldap-password-read): Handle password-cache being + nil. + 2014-11-13 Thomas Fitzsimmons * net/eudc.el (eudc-expand-inline): Always restore former server diff --git a/lisp/net/ldap.el b/lisp/net/ldap.el index 32e403a8718..477c21b0145 100644 --- a/lisp/net/ldap.el +++ b/lisp/net/ldap.el @@ -487,16 +487,16 @@ Additional search parameters can be specified through "Read LDAP password for HOST. If the password is cached, it is read from the cache, otherwise the user is prompted for the password and the password is cached. The cache can be cleared -with `password-reset`." - ;; Add ldap: namespace to allow empty string for default host. - (let ((host-key (concat "ldap:" host))) - (when (not (password-in-cache-p host-key)) - (password-cache-add host-key (password-read - (format "Enter LDAP Password%s: " - (if (equal host "") - "" - (format " for %s" host)))))) - (password-read-from-cache host-key))) +with the `password-reset' function and the +`password-cache-expiry' variable controls how long the password +is cached for." + (password-read-and-add + (format "Enter LDAP Password%s: " + (if (equal host "") + "" + (format " for %s" host))) + ;; Add ldap: namespace to allow empty string for default host. + (concat "ldap:" host))) (defun ldap-search-internal (search-plist) "Perform a search on a LDAP server.