From: João Távora <joaotavora@gmail.com>
Date: Thu, 21 Sep 2017 13:20:22 +0000 (+0100)
Subject: Echo Flymake error messages when navigating errors interactively
X-Git-Tag: emacs-26.0.90~56^2^2~26
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=8c85ab027eefb352a39d68433f64bfaa1c446856;p=emacs.git

Echo Flymake error messages when navigating errors interactively

Perhaps binding M-n and M-p to flymake-goto-next-error and
flymake-goto-prev-error also wouldn't be a bad idea.

* lisp/progmodes/flymake.el (flymake-goto-next-error): Use
target overlay's help-echo.
---

diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index e8d5de6023c..f9aa098071b 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -557,15 +557,19 @@ return DEFAULT."
          (chain (cl-member-if (lambda (ov)
                                 (if (cl-plusp n)
                                     (> (overlay-start ov)
-					(point))
-				  (< (overlay-start ov)
-				      (point))))
-			      ovs))
-	 (target (nth (1- n) chain)))
-    (if target
-	(goto-char (overlay-start target))
-      (when interactive
-	(user-error "No more flymake errors")))))
+                                       (point))
+                                  (< (overlay-start ov)
+                                     (point))))
+                              ovs))
+         (target (nth (1- n) chain)))
+    (cond (target
+           (goto-char (overlay-start target))
+           (when interactive
+             (message
+              (funcall (overlay-get target 'help-echo)
+                       nil nil (point)))))
+          (interactive
+           (user-error "No more flymake errors")))))
 
 (defun flymake-goto-prev-error (&optional n interactive)
   "Go to previous, or Nth previous, flymake error in buffer."