From: Brian Leung Date: Sun, 23 Jan 2022 03:59:06 +0000 (-0800) Subject: Properly check the completionitem.deprecated property X-Git-Tag: emacs-29.0.90~1616^2~524^2~4^2~74 X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=8b31247f1c6626b289e75460e0d0978bf446e05a;p=emacs.git Properly check the completionitem.deprecated property * eglot.el (eglot-completion-at-point): Check the :deprecated property is `t'. We do this so that a :deprecated property of :json-false does not cause a completion candidate to be incorrectly marked as deprecated. --- diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 957ddde68c2..5a0a8caba48 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -2472,7 +2472,7 @@ is not active." (when-let ((lsp-item (get-text-property 0 'eglot--lsp-item proxy))) (or (seq-contains-p (plist-get lsp-item :tags) 1) - (plist-get lsp-item :deprecated)))) + (eq t (plist-get lsp-item :deprecated))))) :company-docsig ;; FIXME: autoImportText is specific to the pyright language server (lambda (proxy)