From: Eshel Yaron <me@eshelyaron.com>
Date: Wed, 10 Apr 2024 19:55:38 +0000 (+0200)
Subject: ; Remove obsolete 'mouse-wheel-up/down-event' bindings
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=8a37ce3d1637ca4a048ce165393c20863acd8323;p=emacs.git

; Remove obsolete 'mouse-wheel-up/down-event' bindings

Following commit e720ba62193 'mouse-wheel-up-event' and
'mouse-wheel-down-event' are translated to 'wheel-up/down'
events, so we only need to bind 'wheel-down/up' in
'completion-preview--mouse-map'.

* lisp/completion-preview.el: Don't require 'mwheel'.
(completion-preview--mouse-map): Remove bindings for
'mouse-wheel-up/down-event'.

(cherry picked from commit 3a91186ad3707c7e3754616f1c7a2735d40fc33d)
---

diff --git a/lisp/completion-preview.el b/lisp/completion-preview.el
index e889d64657c..3d99ade64e7 100644
--- a/lisp/completion-preview.el
+++ b/lisp/completion-preview.el
@@ -52,8 +52,6 @@
 
 ;;; Code:
 
-(require 'mwheel)
-
 (defgroup completion-preview nil
   "In-buffer completion preview."
   :group 'completion)
@@ -135,18 +133,8 @@ If this option is nil, these commands do not display any message."
   "<down-mouse-1>" #'completion-preview-insert
   "C-<down-mouse-1>" #'completion-at-point
   "<down-mouse-2>" #'completion-at-point
-  ;; BEWARE: `mouse-wheel-UP-event' corresponds to `wheel-DOWN' events
-  ;; and vice versa!!
   "<wheel-up>"     #'completion-preview-prev-candidate
-  "<wheel-down>"   #'completion-preview-next-candidate
-  (key-description (with-suppressed-warnings
-                       ((obsolete mouse-wheel-up-event))
-                     (vector mouse-wheel-up-event)))
-  #'completion-preview-next-candidate
-  (key-description (with-suppressed-warnings
-                       ((obsolete mouse-wheel-down-event))
-                     (vector mouse-wheel-down-event)))
-  #'completion-preview-prev-candidate)
+  "<wheel-down>"   #'completion-preview-next-candidate)
 
 (defvar-local completion-preview--overlay nil)