From: João Távora <joaotavora@gmail.com>
Date: Sat, 18 Aug 2018 11:26:55 +0000 (+0100)
Subject: Don't error if server replies with empty hover message
X-Git-Tag: emacs-29.0.90~1616^2~524^2~4^2~441
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=88e9d97119dbb8879b74634b88d1c8e7da2bb5a4;p=emacs.git

Don't error if server replies with empty hover message

* eglot.el (eglot-eldoc-function): Check non-nil contents.

GitHub-reference: per https://github.com/joaotavora/eglot/issues/74
---

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index 6f3676117a7..3fd98c7d800 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -1512,7 +1512,9 @@ If SKIP-SIGNATURE, don't try to send textDocument/signatureHelp."
          :success-fn (jsonrpc-lambda (&key contents range)
                        (unless sig-showing
                          (when-buffer-window
-                          (when-let (info (eglot--hover-info contents range))
+                          (when-let (info (and contents
+                                               (eglot--hover-info contents
+                                                                  range)))
                             (eldoc-message info)))))
          :deferred :textDocument/hover))
       (when (eglot--server-capable :documentHighlightProvider)