From: Basil L. Contovounesios <contovob@tcd.ie>
Date: Wed, 18 Nov 2020 11:47:54 +0000 (+0000)
Subject: Don't make bibtex-unify-case-convert buffer-local
X-Git-Tag: emacs-28.0.90~5118
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=88d5b1d3253728bd314de36544996aa15345bd29;p=emacs.git

Don't make bibtex-unify-case-convert buffer-local

The :local tag does not currently work as intended (it results in a
default value of bibtex-unify-case-convert of nil rather than
identity), and no other bibtex.el user option is automatically
buffer-local, so revert this recent change.

For discussion, see the following emacs-devel thread:
https://lists.gnu.org/r/emacs-devel/2020-11/msg00734.html

* lisp/textmodes/bibtex.el (bibtex-unify-case-convert): Don't make
automatically buffer-local for consistency with other user options,
and because the :local tag doesn't have the intended results.
---

diff --git a/lisp/textmodes/bibtex.el b/lisp/textmodes/bibtex.el
index d53cfa0b1ff..c9e21e58f62 100644
--- a/lisp/textmodes/bibtex.el
+++ b/lisp/textmodes/bibtex.el
@@ -96,8 +96,7 @@ It is called with one argument, the entry or field name."
 		 (const :tag "Downcase" downcase)
 		 (const :tag "Capitalize" capitalize)
 		 (const :tag "Upcase" upcase)
-                 (function :tag "Conversion function"))
-  :local t)
+                 (function :tag "Conversion function")))
 
 (defcustom bibtex-user-optional-fields
   '(("annote" "Personal annotation (ignored)"))