From: Richard M. Stallman <rms@gnu.org>
Date: Fri, 15 May 1998 20:35:58 +0000 (+0000)
Subject: (ange-ftp-start-process): Handle Windows ftp client.
X-Git-Tag: emacs-20.3~1001
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=85348a1744b43cd3a800ac1bed2f2e4b0d30b6f7;p=emacs.git

(ange-ftp-start-process): Handle Windows ftp client.
---

diff --git a/lisp/ange-ftp.el b/lisp/ange-ftp.el
index 7230044e499..bd190091ec3 100644
--- a/lisp/ange-ftp.el
+++ b/lisp/ange-ftp.el
@@ -1974,7 +1974,23 @@ on the gateway machine to do the ftp instead."
     (process-kill-without-query proc)
     (set-process-sentinel proc (function ange-ftp-process-sentinel))
     (set-process-filter proc (function ange-ftp-process-filter))
-    (accept-process-output proc)	;wait for ftp startup message
+    ;; wait for ftp startup message
+    (if (not (eq system-type 'windows-nt))
+	(accept-process-output proc)
+      ;; On Windows, the standard ftp client behaves a little oddly,
+      ;; initially buffering its output (because stdin/out are pipe
+      ;; handles).  As a result, the startup message doesn't appear
+      ;; until enough output is generated to flush stdout, so a plain
+      ;; accept-process-output call at this point would hang
+      ;; indefinitely.  So if nothing appears within 2 seconds, we try
+      ;; sending an innocuous command ("help foo") that forces some
+      ;; output.  Curiously, once we start sending normal commands, the
+      ;; output no longer appears to be buffered, and everything works
+      ;; correctly (or at least appears to!).
+      (if (accept-process-output proc 2)
+	  nil
+ 	(process-send-string proc "help foo\n")
+	(accept-process-output proc)))
     proc))
 
 (put 'internal-ange-ftp-mode 'mode-class 'special)