From: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Mon, 25 Apr 2011 16:52:51 +0000 (-0300)
Subject: * lisp/custom.el (defcustom): Obey lexical-binding.
X-Git-Tag: emacs-pretest-24.0.90~104^2~275^2~215^2~6
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=850256b5e9fa9f03008b843e58b1b338d86877f5;p=emacs.git

* lisp/custom.el (defcustom): Obey lexical-binding.
---

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index ed4aafa0ef5..13c6bfa2d4c 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,5 +1,7 @@
 2011-04-25  Stefan Monnier  <monnier@iro.umontreal.ca>
 
+	* custom.el (defcustom): Obey lexical-binding.
+
 	Fix octave-inf completion problems reported by Alexander Klimov.
 	* progmodes/octave-inf.el (inferior-octave-mode-syntax-table):
 	Inherit from octave-mode-syntax-table.
diff --git a/lisp/custom.el b/lisp/custom.el
index 9673db47ea8..8295777f1f1 100644
--- a/lisp/custom.el
+++ b/lisp/custom.el
@@ -313,11 +313,19 @@ for more information."
   ;; It is better not to use backquote in this file,
   ;; because that makes a bootstrapping problem
   ;; if you need to recompile all the Lisp files using interpreted code.
-  (nconc (list 'custom-declare-variable
-	       (list 'quote symbol)
-	       (list 'quote value)
-	       doc)
-	 args))
+  `(custom-declare-variable
+    ',symbol
+    ,(if lexical-binding    ;FIXME: This is not reliable, but is all we have.
+         ;; The `default' arg should be an expression that evaluates to
+         ;; the value to use.  The use of `eval' for it is spread over
+         ;; many different places and hence difficult to eliminate, yet
+         ;; we want to make sure that the `value' expression is checked by the
+         ;; byte-compiler, and that lexical-binding is obeyed, so quote the
+         ;; expression with `lambda' rather than with `quote'.
+         `(list (lambda () ,value))
+       `',value)
+    ,doc
+    ,@args))
 
 ;;; The `defface' Macro.