From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sun, 25 Aug 2019 00:46:21 +0000 (-0700)
Subject: Clarify Fx_parse_geometry initialization
X-Git-Tag: emacs-27.0.90~1328^2~81
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=84f1674ee8cbd83ea219595e9adec2d148946976;p=emacs.git

Clarify Fx_parse_geometry initialization

* src/frame.c (Fx_parse_geometry): Clarify why local init
isn’t needed.
---

diff --git a/src/frame.c b/src/frame.c
index 330f98aee15..cf38c85f09f 100644
--- a/src/frame.c
+++ b/src/frame.c
@@ -5327,9 +5327,10 @@ or a list (- N) meaning -N pixels relative to bottom/right corner.
 On Nextstep, this just calls `ns-parse-geometry'.  */)
   (Lisp_Object string)
 {
-  int geometry, x UNINIT, y UNINIT;
+  /* x and y don't need initialization, as they are not accessed
+     unless XParseGeometry sets them.  */
+  int x UNINIT, y UNINIT;
   unsigned int width, height;
-  Lisp_Object result;
 
   CHECK_STRING (string);
 
@@ -5337,9 +5338,9 @@ On Nextstep, this just calls `ns-parse-geometry'.  */)
   if (strchr (SSDATA (string), ' ') != NULL)
     return call1 (Qns_parse_geometry, string);
 #endif
-  geometry = XParseGeometry (SSDATA (string),
-			     &x, &y, &width, &height);
-  result = Qnil;
+  int geometry = XParseGeometry (SSDATA (string),
+				 &x, &y, &width, &height);
+  Lisp_Object result = Qnil;
   if (geometry & XValue)
     {
       Lisp_Object element;