From: muffinmad <andreyk.mad@gmail.com>
Date: Mon, 28 Nov 2022 21:09:59 +0000 (+0200)
Subject: Insert news for installed packages only
X-Git-Tag: emacs-29.0.90~1410
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=832b013ef041b13a55f9ccf6e1eca617f605753c;p=emacs.git

Insert news for installed packages only

* lisp/emacs-lisp/package.el (describe-package-1): Check package is
installed and "news" is a regular file.  (Bug#59684)
---

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 8e7c34da383..f10dc915721 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -2696,7 +2696,10 @@ Helper function for `describe-package'."
          (signed (if desc (package-desc-signed desc)))
          (maintainer (cdr (assoc :maintainer extras)))
          (authors (cdr (assoc :authors extras)))
-         (news (and-let* ((file (expand-file-name "news" pkg-dir))
+         (news (and-let* (pkg-dir
+                          ((not built-in))
+                          (file (expand-file-name "news" pkg-dir))
+                          ((file-regular-p file))
                           ((file-readable-p file)))
                  file)))
     (when (string= status "avail-obso")