From: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Sun, 5 Nov 2000 19:07:07 +0000 (+0000)
Subject: (regexp-opt-group): Sort the strings when extracting a suffix.
X-Git-Tag: emacs-pretest-21.0.90~305
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=7e1d6bdb408f48b3efe2168d52283af44087d481;p=emacs.git

(regexp-opt-group): Sort the strings when extracting a suffix.
---

diff --git a/lisp/emacs-lisp/regexp-opt.el b/lisp/emacs-lisp/regexp-opt.el
index de36f1d5446..e849cd60b96 100644
--- a/lisp/emacs-lisp/regexp-opt.el
+++ b/lisp/emacs-lisp/regexp-opt.el
@@ -205,7 +205,10 @@ so we can use character sets rather than grouping parenthesis."
 	    (if (> (length xiffus) 0)
 		;; common suffix: take it and recurse on the prefixes.
 		(let* ((n (- (length xiffus)))
-		       (prefixes (mapcar (lambda (s) (substring s 0 n)) strings)))
+		       (prefixes
+			;; Sorting is necessary in cases such as ("ad" "d").
+			(sort (mapcar (lambda (s) (substring s 0 n)) strings)
+			      'string-lessp)))
 		  (concat open-group
 			  (regexp-opt-group prefixes t t)
 			  (regexp-quote