From: Po Lu <luangruo@yahoo.com>
Date: Fri, 13 May 2022 08:08:54 +0000 (+0800)
Subject: Improve test for empty help-echo on NS menu bar items
X-Git-Tag: emacs-29.0.90~1910^2~741
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=7dd4e0b72ebb9682f4042a044b4ba5bf494c996e;p=emacs.git

Improve test for empty help-echo on NS menu bar items

* src/nsmenu.m ([EmacsMenu menu:willHighlightItem:]): Also check
if idx is valid.
---

diff --git a/src/nsmenu.m b/src/nsmenu.m
index 9f4825ac140..5599d519063 100644
--- a/src/nsmenu.m
+++ b/src/nsmenu.m
@@ -782,7 +782,7 @@ prettify_key (const char *key)
     }
   /* Just dismiss any help-echo that might already be in progress if
      no menu item will be highlighted.  */
-  else if (item == nil)
+  else if (item == nil || idx <= 0)
     help = Qnil;
   else
     {