From: Eli Zaretskii <eliz@gnu.org>
Date: Sun, 25 Aug 2024 12:46:05 +0000 (+0300)
Subject: Remove dangerous HTML edit from admin.el
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=7a7eb2794b8bf4928c64b5d780818f5d46c9c81c;p=emacs.git

Remove dangerous HTML edit from admin.el

* admin/admin.el (manual-html-fix-index-2): Avoid lax matches with
"<ul>" which could mistakenly edit unrelated parts of HTML.
(Bug#72761)

(cherry picked from commit 969498c25d0112dbdc3aa2ef75dc63681101203e)
---

diff --git a/admin/admin.el b/admin/admin.el
index a4d3720ab69..edd3246a1a3 100644
--- a/admin/admin.el
+++ b/admin/admin.el
@@ -613,9 +613,7 @@ style=\"text-align:left\">")
       ;; item is not there anymore.  So for HTML manuals produced by
       ;; those newer versions of Texinfo we punt and leave the menu in
       ;; its original form.
-      (when (or (search-forward "<ul class=\"menu\">" nil t)
-	        ;; FIXME?  The following search seems dangerously lax.
-	        (search-forward "<ul>" nil t))
+      (when (or (search-forward "<ul class=\"menu\">" nil t))
         ;; Convert the list that Makeinfo made into a table.
         (replace-match "<table style=\"float:left\" width=\"100%\">")
         (forward-line 1)