From: Lars Ingebrigtsen Date: Sat, 4 Dec 2021 04:56:32 +0000 (+0100) Subject: Improve bookmark-maybe-historicize-string doc string X-Git-Tag: emacs-29.0.90~3617^2~23 X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=7505abae3968f9ecdc2e0be909bfffed822f9fdb;p=emacs.git Improve bookmark-maybe-historicize-string doc string * lisp/bookmark.el (bookmark-maybe-historicize-string): Clarify that this isn't about menus (but calls from bmenu) (bug#12504). --- diff --git a/lisp/bookmark.el b/lisp/bookmark.el index a8fa9ae7749..f35cbc1a5ec 100644 --- a/lisp/bookmark.el +++ b/lisp/bookmark.el @@ -510,8 +510,9 @@ If DEFAULT is nil then return empty string for empty input." (defmacro bookmark-maybe-historicize-string (string) "Put STRING into the bookmark prompt history, if caller non-interactive. -We need this because sometimes bookmark functions are invoked from -menus, so `completing-read' never gets a chance to set `bookmark-history'." +We need this because sometimes bookmark functions are invoked +from other commands that pass in the bookmark name, so +`completing-read' never gets a chance to set `bookmark-history'." `(or (called-interactively-p 'interactive) (setq bookmark-history (cons ,string bookmark-history))))