From: João Távora <joaotavora@gmail.com>
Date: Thu, 9 Nov 2017 20:44:11 +0000 (+0000)
Subject: Protect Flymake checkdoc backend against checkdoc errors (bug#29176)
X-Git-Tag: emacs-26.0.91~343
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=72e62d3fdb2b24dd9808f49fbbd864715337d2bf;p=emacs.git

Protect Flymake checkdoc backend against checkdoc errors (bug#29176)

The function checkdoc-current-buffer may error if there are unbalanced
parens, for example, but this shouldn't disable the
elisp-flymake-checkdoc backend.

* lisp/progmodes/elisp-mode.el (elisp-flymake-checkdoc): Use
ignore-errors.
---

diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el
index 41415943a58..5ba09789097 100644
--- a/lisp/progmodes/elisp-mode.el
+++ b/lisp/progmodes/elisp-mode.el
@@ -1615,7 +1615,11 @@ Calls REPORT-FN directly."
             (generate-new-buffer " *checkdoc-temp*")))
       (unwind-protect
           (save-excursion
-            (checkdoc-current-buffer t))
+            ;; checkdoc-current-buffer can error if there are
+            ;; unbalanced parens, for example, but this shouldn't
+            ;; disable the backend (bug#29176).
+            (ignore-errors
+              (checkdoc-current-buffer t)))
         (kill-buffer checkdoc-diagnostic-buffer)))
     (funcall report-fn
              (cl-loop for (text start end _unfixable) in