From: Richard M. Stallman <rms@gnu.org>
Date: Tue, 15 Feb 1994 16:17:25 +0000 (+0000)
Subject: (XTread_socket): Do not assume that select returning
X-Git-Tag: emacs-19.34~9899
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=7071e5ddb787a0b5a06fbb48c496507790e52181;p=emacs.git

(XTread_socket): Do not assume that select returning
immediately with no events implies a hangup.
---

diff --git a/src/xterm.c b/src/xterm.c
index e9d57fac40d..673f6ff6230 100644
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -3628,10 +3628,15 @@ XTread_socket (sd, bufp, numchars, waitp, expected)
 #ifdef X_IO_BUG
   if (! event_found)
     /* On some systems, an X bug causes Emacs to get no more events
-       when the window is destroyed.  Detect that.  */
+       when the window is destroyed.  Detect that.  (1994.)  */
     XNoOp (x_current_display);
 #endif /* X_IO_BUG */
 
+#if 0 /* This fails for serial-line connections to the X server, 
+	 because the characters arrive one by one, and a partial
+	 command makes select return but gives nothing to read.
+	 We'll have to hope that the bug that this tried to fix
+	 in 1988 has been fixed in Xlib or the X server.  */
 #ifdef HAVE_SELECT
   if (expected && ! event_found)
     {
@@ -3652,6 +3657,7 @@ XTread_socket (sd, bufp, numchars, waitp, expected)
 	kill (getpid (), SIGHUP);
     }
 #endif /* HAVE_SELECT */
+#endif /* 0 */
 
 #ifndef HAVE_X11
   if (updating_frame == 0)