From: Tino Calancha Date: Thu, 1 Oct 2020 21:33:56 +0000 (+0200) Subject: Fix wdired-do-perm-changes when over Tramp X-Git-Tag: emacs-28.0.90~5776 X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=6996204dd036650b7e1e7f9580055fefb033abe5;p=emacs.git Fix wdired-do-perm-changes when over Tramp * lisp/wdired.el (wdired-do-perm-changes) Use set-file-modes instead of external program (bug#39284). This fixes the problem of passing the wrong argument to the external chmod. --- diff --git a/lisp/wdired.el b/lisp/wdired.el index 806eb304d9f..40f4cd97190 100644 --- a/lisp/wdired.el +++ b/lisp/wdired.el @@ -913,9 +913,9 @@ Like original function but it skips read-only words." (if (= (length perms-new) 10) (progn (setq perm-tmp - (int-to-string (wdired-perms-to-number perms-new))) - (unless (equal 0 (process-file dired-chmod-program - nil nil nil perm-tmp filename)) + (string-to-number + (int-to-string (wdired-perms-to-number perms-new)) 8)) + (unless (set-file-modes filename perm-tmp) (setq errors (1+ errors)) (dired-log "%s %s `%s' failed\n\n" dired-chmod-program perm-tmp filename)))