From: João Távora <joaotavora@gmail.com>
Date: Mon, 27 Jul 2020 15:26:33 +0000 (+0100)
Subject: Bring back ElDoc's eldoc-display-message-p, but obsolete it
X-Git-Tag: emacs-28.0.90~6926
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=688c03f41278a33f580b56c2122d7f52c9a3ed67;p=emacs.git

Bring back ElDoc's eldoc-display-message-p, but obsolete it

Like others, this is an implementation detail that third parties could
be relying on.  Better not remove it outright just now, since its
implementation is very simple anyway.

* lisp/emacs-lisp/eldoc.el (Version): Bump to 1.7.0
(eldoc-display-message-p): Bring back, but obsolete.
---

diff --git a/lisp/emacs-lisp/eldoc.el b/lisp/emacs-lisp/eldoc.el
index fcb104e5477..b30836cc0bd 100644
--- a/lisp/emacs-lisp/eldoc.el
+++ b/lisp/emacs-lisp/eldoc.el
@@ -5,7 +5,7 @@
 ;; Author: Noah Friedman <friedman@splode.com>
 ;; Keywords: extensions
 ;; Created: 1995-10-06
-;; Version: 1.6.0
+;; Version: 1.7.0
 ;; Package-Requires: ((emacs "26.3"))
 
 ;; This is a GNU ELPA :core package.  Avoid functionality that is not
@@ -346,6 +346,12 @@ Also store it in `eldoc-last-message' and return that value."
   "Compute information to store in `eldoc--last-request-state'."
   (list (current-buffer) (buffer-modified-tick) (point)))
 
+(defun eldoc-display-message-p ()
+  (eldoc--request-docs-p (eldoc--request-state)))
+(make-obsolete 'eldoc-display-message-p
+               "Use `eldoc-documentation-functions' instead."
+               "eldoc-1.6.0")
+
 (defun eldoc--request-docs-p (request-state)
   "Return non-nil when it is appropriate to request docs.
 REQUEST-STATE is a candidate for `eldoc--last-request-state'"