From: Sean Whitton <spwhitton@spwhitton.name>
Date: Sun, 20 Oct 2024 01:20:07 +0000 (+0800)
Subject: ; * lisp/vc/log-view.el (log-view-modify-change-comment): Add FIXME.
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=676f751b470e41d9d4bd79320e9ffd56f76dfede;p=emacs.git

; * lisp/vc/log-view.el (log-view-modify-change-comment): Add FIXME.

(cherry picked from commit de0800c511740de7ad4dcb7dda0a0083a094d749)
---

diff --git a/lisp/vc/log-view.el b/lisp/vc/log-view.el
index 647a7dc569f..360f522272b 100644
--- a/lisp/vc/log-view.el
+++ b/lisp/vc/log-view.el
@@ -550,6 +550,12 @@ If called interactively, visit the version at point."
          (rev (log-view-current-tag))
          ;; `log-view-extract-comment' is the legacy code for this; the
          ;; `get-change-comment' backend action is the new way to do it.
+         ;;
+         ;; FIXME: Eventually the older backends should have
+         ;; implementations of `get-change-comment' because that ought
+         ;; to be more robust than the approach taken by
+         ;; `log-view-extract-comment'.  Then we can delete the latter.
+         ;; See discussion in bug#64055.  --spwhitton
          (comment (condition-case _
                       (vc-call-backend log-view-vc-backend
                                        'get-change-comment files rev)