From: Oleh Krehel <ohwoeowho@gmail.com>
Date: Thu, 17 Sep 2020 18:43:34 +0000 (+0200)
Subject: Make face names clickable in Customize buffers
X-Git-Tag: emacs-28.0.90~6027
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=65b7d465a5e5afaa5332cb8d24b0834ebb7633fc;p=emacs.git

Make face names clickable in Customize buffers

* lisp/cus-edit.el (custom-face-value-create): Make the face name
a clickable button (bug#20664).
---

diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el
index 6d0ec5d1486..9626b3cf810 100644
--- a/lisp/cus-edit.el
+++ b/lisp/cus-edit.el
@@ -3560,19 +3560,20 @@ the present value is saved to its :shown-value property instead."
 	  (widget-put widget :buttons buttons))
 
       ;; Draw an ordinary `custom-face' widget
-      (let ((opoint (point)))
-	;; Visibility indicator.
-	(push (widget-create-child-and-convert
-	       widget 'custom-visibility
-	       :help-echo "Hide or show this face."
-	       :on "Hide" :off "Show"
-	       :on-glyph "down" :off-glyph "right"
-	       :action 'custom-toggle-hide-face
-	       (not hiddenp))
-	      buttons)
-	;; Face name (tag).
-	(insert " " tag)
-	(widget-specify-sample widget opoint (point)))
+      ;; Visibility indicator.
+      (push (widget-create-child-and-convert
+             widget 'custom-visibility
+             :help-echo "Hide or show this face."
+             :on "Hide" :off "Show"
+             :on-glyph "down" :off-glyph "right"
+             :action 'custom-toggle-hide-face
+             (not hiddenp))
+            buttons)
+      ;; Face name (tag).
+      (insert " ")
+      (insert-text-button tag
+                          'action (lambda (&rest _x)
+                                    (find-face-definition symbol)))
       (insert
        (cond ((eq custom-buffer-style 'face) " ")
 	     ((string-match-p "face\\'" tag)   ":")