From: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Thu, 30 May 2024 22:57:56 +0000 (-0400)
Subject: ad-activate-advised-definition: Use proper function objects
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=647b489cdffab43432538ef966c31f714dae2824;p=emacs.git

ad-activate-advised-definition: Use proper function objects

* lisp/emacs-lisp/advice.el (ad-activate-advised-definition):
Use interpreted functions rather than lambda lists.

(cherry picked from commit 2e16bcd8ede77e41e0caaf71e1d22edadadc79dd)
---

diff --git a/lisp/emacs-lisp/advice.el b/lisp/emacs-lisp/advice.el
index 752660156b9..73d11fc8aa8 100644
--- a/lisp/emacs-lisp/advice.el
+++ b/lisp/emacs-lisp/advice.el
@@ -2845,7 +2845,11 @@ The current definition and its cache-id will be put into the cache."
          (old-ispec (interactive-form advicefunname)))
     (fset advicefunname
           (or verified-cached-definition
-              (ad-make-advised-definition function)))
+              (eval
+               (ad-make-advised-definition function)
+               ;; We don't keep track of the `lexical-binding' of the
+               ;; various chunks: assume it's the old dynbound dialect.
+               nil)))
     (put advicefunname 'function-documentation
 	 `(ad--make-advised-docstring ',advicefunname))
     (unless (equal (interactive-form advicefunname) old-ispec)