From: Alan Mackenzie <acm@muc.de>
Date: Sat, 27 Jan 2018 22:02:45 +0000 (+0000)
Subject: Allow read-passwd to hide characters inserted by C-y.  (Security fix.)
X-Git-Tag: emacs-26.1-rc1~305
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=6415b2d;p=emacs.git

Allow read-passwd to hide characters inserted by C-y.  (Security fix.)

This fixes bug #30186.  The with-silent-modifications was there to prevent
records of text property manipulations being put into buffer-undo-list.  These
had been causing a significant slowdown in CC Mode with C-_ after a large
C-y.  This CC Mode problem has since been solved by a different workaround.

* lisp/subr.el (remove-yank-excluded-properties): Remove the invocation of
with-silent-modifications around the text property manipulations.
---

diff --git a/lisp/subr.el b/lisp/subr.el
index 052d9cd8216..64cbbd52ab8 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -3019,10 +3019,9 @@ remove properties specified by `yank-excluded-properties'."
                           run-start prop nil end)))
             (funcall fun value run-start run-end)
             (setq run-start run-end)))))
-    (with-silent-modifications
-      (if (eq yank-excluded-properties t)
-          (set-text-properties start end nil)
-        (remove-list-of-text-properties start end yank-excluded-properties)))))
+    (if (eq yank-excluded-properties t)
+        (set-text-properties start end nil)
+      (remove-list-of-text-properties start end yank-excluded-properties))))
 
 (defvar yank-undo-function)