From: Jason Rumney <jasonr@gnu.org>
Date: Sun, 18 Apr 2004 18:34:03 +0000 (+0000)
Subject: (Fw32_set_clipboard_data): Get sequence number after closing the clipboard.
X-Git-Tag: ttn-vms-21-2-B4~6741
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=6383ca22fcf6d37fffdd4fe729a937409c70801b;p=emacs.git

(Fw32_set_clipboard_data): Get sequence number after closing the clipboard.
---

diff --git a/src/w32select.c b/src/w32select.c
index 940cce35772..0c8849c7be6 100644
--- a/src/w32select.c
+++ b/src/w32select.c
@@ -259,11 +259,18 @@ DEFUN ("w32-set-clipboard-data", Fw32_set_clipboard_data,
 
   ok = EmptyClipboard () && SetClipboardData (CF_TEXT, htext);
 
+  CloseClipboard ();
+
+  /* Common sense says to read the sequence number inside the
+     OpenClipboard/ CloseClipboard block to avoid race conditions
+     where another app puts something on the clipboard straight after
+     us. But experience suggests that the sequence number from the
+     SetClipboardData is not allocated until we close the clipboard!
+     Since clipboard operations are normally user-driven, the race
+     condition is probably not going to really happen.  */
   if (clipboard_sequence_fn)
     last_clipboard_sequence_number = clipboard_sequence_fn ();
 
-  CloseClipboard ();
-
   if (ok) goto done;
 
  error: