From: Philipp Stephani <phst@google.com>
Date: Sat, 17 Jun 2017 15:10:41 +0000 (+0200)
Subject: ; * src/emacs-module.c (funcall_module): Add another FIXME
X-Git-Tag: emacs-26.0.90~521^2~50
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=61dc103969fce1a0bf179e9e799d1feba128b525;p=emacs.git

; * src/emacs-module.c (funcall_module): Add another FIXME
---

diff --git a/src/emacs-module.c b/src/emacs-module.c
index 5c413ee0556..2693a4529d6 100644
--- a/src/emacs-module.c
+++ b/src/emacs-module.c
@@ -768,6 +768,9 @@ funcall_module (Lisp_Object function, ptrdiff_t nargs, Lisp_Object *arglist)
   USE_SAFE_ALLOCA;
   ATTRIBUTE_MAY_ALIAS emacs_value *args;
   if (plain_values && ! module_assertions)
+    /* FIXME: The cast below is incorrect because the argument array
+       is not declared as const, so module functions can modify it.
+       Either declare it as const, or remove this branch.  */
     args = (emacs_value *) arglist;
   else
     {