From: João Távora Date: Mon, 1 Feb 2021 14:03:23 +0000 (+0000) Subject: Also override global flymake-diagnostic-functions X-Git-Tag: emacs-29.0.90~1616^2~524^2~4^2~173 X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=60724b8c522ff2ef30429170223c1595c47a4d17;p=emacs.git Also override global flymake-diagnostic-functions The global value of the flymake-diagnostic-functions is likely to be of little use in Eglot-managed buffers, so don't run it. Likely the value flymake-proc-legacy-flymake is there which is not only likely of little uses but also causes trouble in some situations. The user can easily avert this by leveraging the variable eglot-stay-out-of. * eglot.el (eglot--managed-mode): Don't run global flymake-diagnostic-functions. GitHub-reference: fix https://github.com/joaotavora/eglot/issues/616 --- diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index f3b006da1ae..3ea8a2fa7e1 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -1367,7 +1367,7 @@ Use `eglot-managed-p' to determine if current buffer is managed.") (eglot--setq-saving eldoc-documentation-strategy #'eldoc-documentation-enthusiast) (eglot--setq-saving xref-prompt-for-identifier nil) - (eglot--setq-saving flymake-diagnostic-functions '(eglot-flymake-backend t)) + (eglot--setq-saving flymake-diagnostic-functions '(eglot-flymake-backend)) (eglot--setq-saving company-backends '(company-capf)) (eglot--setq-saving company-tooltip-align-annotations t) (when (assoc 'flex completion-styles-alist)