From: Mattias Engdegård <mattiase@acm.org>
Date: Tue, 11 Apr 2023 09:50:17 +0000 (+0200)
Subject: allout.el: fix subtree expose numbering bug
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=5dab172a17320e93332ae6545738b37f4224f2de;p=emacs.git

allout.el: fix subtree expose numbering bug

* lisp/allout.el (allout-process-exposed): Reverse the list of indices
properly so that the correct numbering for nodes in a subtree is used.
Avoid destructive reversing; the list may be a constant (literal).
This flaw was revealed by an ignored-return-value warning.
---

diff --git a/lisp/allout.el b/lisp/allout.el
index 4d5d814ae01..be2fd632c69 100644
--- a/lisp/allout.el
+++ b/lisp/allout.el
@@ -5390,7 +5390,7 @@ Defaults:
     ;; not specified -- default it:
     (setq tobuf (concat "*" (buffer-name frombuf) " exposed*")))
   (if (listp format)
-      (nreverse format))
+      (setq format (reverse format)))
 
   (let* ((listified
 	  (progn (set-buffer frombuf)