From: Alan Mackenzie <acm@muc.de>
Date: Sun, 29 Nov 2015 16:17:07 +0000 (+0000)
Subject: Byte compiler: Catch missing argument to `funcall'.  Fixes bug#22051.
X-Git-Tag: emacs-25.0.90~603
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=5cf012a3a86e700b5f229fc14d9abd1e27fdb5f4;p=emacs.git

Byte compiler: Catch missing argument to `funcall'.  Fixes bug#22051.

* lisp/emacs-lisp/bytecomp.el (byte-compile-funcall): When there's no argument
to `funcall', (i) Output an error message; (ii) Generate code to signal a
`wrong-number-of-arguments' error.
---

diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index 8fd2594fec8..14173494eeb 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -4013,8 +4013,13 @@ that suppresses all warnings during execution of BODY."
     (setq byte-compile--for-effect nil)))
 
 (defun byte-compile-funcall (form)
-  (mapc 'byte-compile-form (cdr form))
-  (byte-compile-out 'byte-call (length (cdr (cdr form)))))
+  (if (cdr form)
+      (progn
+        (mapc 'byte-compile-form (cdr form))
+        (byte-compile-out 'byte-call (length (cdr (cdr form)))))
+    (byte-compile-log-warning "`funcall' called with no arguments" nil :error)
+    (byte-compile-form '(signal 'wrong-number-of-arguments '(funcall 0))
+                       byte-compile--for-effect)))
 
 
 ;; let binding