From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sun, 11 Mar 2018 02:26:01 +0000 (-0800)
Subject: Fix create_process bug breaking eudc-expand-inline
X-Git-Tag: emacs-26.1-rc1~103
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=5c91ca8f30098cb2593ca375daa82d25aef03ad7;p=emacs.git

Fix create_process bug breaking eudc-expand-inline

Problem reported by Thomas Fitzsimmons (Bug#30762).
* src/process.c (create_process) [HAVE_PTYS]:
Call setsid even if !PTY_FLAG.
---

diff --git a/src/process.c b/src/process.c
index bccc3ac3992..b201e9b6acc 100644
--- a/src/process.c
+++ b/src/process.c
@@ -2087,9 +2087,9 @@ create_process (Lisp_Object process, char **new_argv, Lisp_Object current_dir)
     {
       /* Make the pty be the controlling terminal of the process.  */
 #ifdef HAVE_PTYS
-      /* First, disconnect its current controlling terminal.  */
-      if (pty_flag)
-	setsid ();
+      /* First, disconnect its current controlling terminal.
+	 Do this even if !PTY_FLAG; see Bug#30762.  */
+      setsid ();
       /* Make the pty's terminal the controlling terminal.  */
       if (pty_flag && forkin >= 0)
 	{