From: Michael Albinus <michael.albinus@gmx.de>
Date: Fri, 20 Jun 2025 16:38:27 +0000 (+0200)
Subject: Improve eglot tests on emba
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=5a046ec25c93d57f2d25924136a54f42b43abea5;p=emacs.git

Improve eglot tests on emba

* test/infra/gitlab-ci.yml (test-eglot): Use packages company and
yasnippet.

* test/lisp/progmodes/eglot-tests.el (eglot--call-with-timeout):
Skip on emba in case of timeout.  (Bug#78730)

(cherry picked from commit e3660a32c78885b9341531cd1b6a8b7e3e163255)
---

diff --git a/test/infra/Dockerfile.emba b/test/infra/Dockerfile.emba
index 62350e6aff9..64cb40fd399 100644
--- a/test/infra/Dockerfile.emba
+++ b/test/infra/Dockerfile.emba
@@ -140,15 +140,14 @@ RUN src/emacs -Q --batch \
     --eval '(setq treesit-extra-load-path (list "/root/.emacs.d/tree-sitter"))' \
     -l admin/tree-sitter/treesit-admin.el \
     --eval '(dolist (lang (mapcar (quote car) \
-                                  (treesit-admin--populated-treesit-language-source-alist))) \
+        (treesit-admin--populated-treesit-language-source-alist))) \
         (treesit-install-language-grammar lang "/root/.emacs.d/tree-sitter"))' \
     --eval '(message "\ntreesit-language-source-alist")' \
     --eval '(message "=============================")' \
     --eval '(message "%s" (pp-to-string treesit-language-source-alist))' \
     --eval '(message "ABI versions\n============")' \
-    --eval \
-        '(dolist (lang (sort (mapcar (quote car) treesit-language-source-alist))) \
-         (message "%s ABI version %d" lang (treesit-language-abi-version lang)))' \
+    --eval '(dolist (lang (sort (mapcar (quote car) treesit-language-source-alist))) \
+        (message "%s ABI version %d" lang (treesit-language-abi-version lang)))' \
     --eval '(message "\ntreesit-admin-check-manual-coverage")' \
     --eval '(message "===================================")' \
     -f treesit-admin-check-manual-coverage \
diff --git a/test/infra/gitlab-ci.yml b/test/infra/gitlab-ci.yml
index 93658347761..8e779028c3d 100644
--- a/test/infra/gitlab-ci.yml
+++ b/test/infra/gitlab-ci.yml
@@ -323,10 +323,11 @@ test-eglot:
     target: emacs-eglot
     # This is needed in order to get a JUnit test report.
     make_params: >-
-      check-expensive TEST_HOME=/root LOGFILES="lisp/progmodes/eglot-tests.log"
-
-    # EMACS_EXTRAOPT="--eval \(use-package\ company\ :ensure\ t\)
-    #                 --eval \(use-package\ yasnippet\ :ensure\ t\)"
+      check-expensive
+      TEST_HOME=/root
+      LOGFILES="lisp/progmodes/eglot-tests.log"
+      EMACS_EXTRAOPT="--eval \(use-package\ company\ :ensure\ t\)
+                      --eval \(use-package\ yasnippet\ :ensure\ t\)"
 
 build-image-tree-sitter:
   stage: platform-images
diff --git a/test/lisp/progmodes/eglot-tests.el b/test/lisp/progmodes/eglot-tests.el
index 2b6e09a4d16..2b98da4134b 100644
--- a/test/lisp/progmodes/eglot-tests.el
+++ b/test/lisp/progmodes/eglot-tests.el
@@ -185,7 +185,9 @@ directory hierarchy."
                 (funcall fn)))
       (cancel-timer timer)
       (when (eq retval timed-out)
-        (error "%s" (concat "Timed out " message))))))
+        (if (getenv "EMACS_EMBA_CI")
+            (ert-skip (concat "Timed out " message))
+          (error "%s" (concat "Timed out " message)))))))
 
 (defun eglot--find-file-noselect (file &optional noerror)
   (unless (or noerror