From: Michael Albinus Date: Sat, 17 Oct 2015 09:20:05 +0000 (+0200) Subject: Solve timimg issues in file-notify-tests.el X-Git-Tag: emacs-25.0.90~1100 X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=57be62f97b8442218f4fa6979cf27b36d5d5f540;p=emacs.git Solve timimg issues in file-notify-tests.el * test/automated/file-notify-tests.el (file-notify-test02-events): Rectify `attribute-change' tests. There are timing issues with gfilenotify. --- diff --git a/test/automated/file-notify-tests.el b/test/automated/file-notify-tests.el index c943d91c2d0..17636486153 100644 --- a/test/automated/file-notify-tests.el +++ b/test/automated/file-notify-tests.el @@ -325,12 +325,24 @@ Don't wait longer than TIMEOUT seconds for the events to be delivered." file-notify--test-tmpfile '(attribute-change) 'file-notify--test-event-handler)) (file-notify--test-with-events - (file-notify--test-timeout) '(attribute-changed attribute-changed) + (file-notify--test-timeout) '(attribute-changed) + (write-region + "any text" nil file-notify--test-tmpfile nil 'no-message) + (set-file-modes file-notify--test-tmpfile 000) + (delete-file file-notify--test-tmpfile)) + (file-notify-rm-watch file-notify--test-desc) + + ;; With gfilenotify, there are timing issues with attribute + ;; changes in a short time period. So we apply 2 tests. + (setq file-notify--test-desc + (file-notify-add-watch + file-notify--test-tmpfile + '(attribute-change) 'file-notify--test-event-handler)) + (file-notify--test-with-events + (file-notify--test-timeout) '(attribute-changed) (write-region "any text" nil file-notify--test-tmpfile nil 'no-message) (set-file-modes file-notify--test-tmpfile 000) - (read-event nil nil 0.1) ; In order to distinguish the events. - (set-file-times file-notify--test-tmpfile '(0 0)) (delete-file file-notify--test-tmpfile)) (file-notify-rm-watch file-notify--test-desc))