From: Earl Hyatt Date: Sat, 29 Mar 2025 21:30:48 +0000 (-0400) Subject: Fix typo in test of read-only cl-defstruct slot. X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=56614caf21e0a117d7a6d6a37e4260b2a107396b;p=emacs.git Fix typo in test of read-only cl-defstruct slot. * test/lisp/emacs-lisp/cl-macs-tests.el (mystruct) (cl-lib-struct-accessors): Use ":read-only" instead of ":readonly". * test/lisp/emacs-lisp/cl-lib-tests.el (cl-lib-struct-accessors): Test using `setf' on read-only accessor to make sure the correct keyword is used. (cherry picked from commit 6f311883d246df87fa3ed9c24dbb39078e3fd69f) --- diff --git a/test/lisp/emacs-lisp/cl-macs-tests.el b/test/lisp/emacs-lisp/cl-macs-tests.el index df612c11a09..18eb386df2c 100644 --- a/test/lisp/emacs-lisp/cl-macs-tests.el +++ b/test/lisp/emacs-lisp/cl-macs-tests.el @@ -520,7 +520,7 @@ collection clause." (:constructor cl-lib--con-1 (&aux (abc 1))) (:constructor cl-lib--con-2 (&optional def) "Constructor docstring.")) "General docstring." - (abc 5 :readonly t) (def nil)) + (abc 5 :read-only t) (def nil)) (ert-deftest cl-lib-struct-accessors () (let ((x (make-mystruct :abc 1 :def 2))) @@ -530,8 +530,9 @@ collection clause." (should (eql (cl-struct-slot-value 'mystruct 'def x) -1)) (should (eql (cl-struct-slot-offset 'mystruct 'abc) 1)) (should-error (cl-struct-slot-offset 'mystruct 'marypoppins)) + (should-error (setf (mystruct-abc x) 3)) (should (pcase (cl-struct-slot-info 'mystruct) - (`((cl-tag-slot) (abc 5 :readonly t) + (`((cl-tag-slot) (abc 5 :read-only t) (def . ,(or 'nil '(nil)))) t)))))