From: Oscar Fuentes <ofv@wanadoo.es>
Date: Sat, 16 Dec 2017 00:34:35 +0000 (+0100)
Subject: Don't compare arguments that can be nil
X-Git-Tag: emacs-27.0.90~6024
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=506270f9c80bf9bd7dad35a2f0aa6f477da6490b;p=emacs.git

Don't compare arguments that can be nil

copy-region-as-kill can be called passing nil as `beg' and
`end'. Magit does that, which caused an error when this advice was in
effect.

* lisp/ses.el (ses--advice-copy-region-as-kill): avoid comparison
  unless `beg' and `end' are non-nil.
---

diff --git a/lisp/ses.el b/lisp/ses.el
index 4c19c70c5da..188992c78fb 100644
--- a/lisp/ses.el
+++ b/lisp/ses.el
@@ -3051,7 +3051,7 @@ We'll assume copying front-sticky properties doesn't make sense, either.
 
 This advice also includes some SES-specific code because otherwise it's too
 hard to override how mouse-1 works."
-  (when (> beg end)
+  (when (and beg end (> beg end))
     (let ((temp beg))
       (setq beg end
 	    end temp)))