From: Sean Whitton <spwhitton@spwhitton.name>
Date: Sun, 20 Oct 2024 08:40:41 +0000 (+0800)
Subject: ; * lisp/vc/log-view.el (log-view-modify-change-comment): Add FIXME.
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=4def27a6cf4cc7c249cc82bb18918068fa5c9394;p=emacs.git

; * lisp/vc/log-view.el (log-view-modify-change-comment): Add FIXME.

(cherry picked from commit 6c928e490d3347cc309eda51cefbc46fba955650)
---

diff --git a/lisp/vc/log-view.el b/lisp/vc/log-view.el
index 360f522272b..783f58575dc 100644
--- a/lisp/vc/log-view.el
+++ b/lisp/vc/log-view.el
@@ -556,6 +556,15 @@ If called interactively, visit the version at point."
          ;; to be more robust than the approach taken by
          ;; `log-view-extract-comment'.  Then we can delete the latter.
          ;; See discussion in bug#64055.  --spwhitton
+         ;;
+         ;; FIXME: We should implement backend actions
+         ;; `get-change-comment' and `modify-change-comment' for Git,
+         ;; bzr and Hg, so that this command works for those backends.
+         ;; As discussed in bug#64055, get-change-comment is required,
+         ;; and parsing the old comment out of the Log View buffer will
+         ;; not do.  This is because for these backends there are
+         ;; `vc-*-log-switches' variables which can change what gets put
+         ;; in the Log View buffers and break any Lisp parsing attempt.
          (comment (condition-case _
                       (vc-call-backend log-view-vc-backend
                                        'get-change-comment files rev)