From: Lars Ingebrigtsen <larsi@gnus.org>
Date: Mon, 29 Nov 2021 15:39:02 +0000 (+0100)
Subject: Signal a better error in tabulated-list-sort
X-Git-Tag: emacs-29.0.90~3639^2~16
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=4de13ef147a4c88c33fe608ee7ca5bd4212476ee;p=emacs.git

Signal a better error in tabulated-list-sort

* lisp/emacs-lisp/tabulated-list.el (tabulated-list-sort): Signal
error earlier on invalid column numbers (bug#52154).
---

diff --git a/lisp/emacs-lisp/tabulated-list.el b/lisp/emacs-lisp/tabulated-list.el
index 8f6c655dbef..075fe836f6b 100644
--- a/lisp/emacs-lisp/tabulated-list.el
+++ b/lisp/emacs-lisp/tabulated-list.el
@@ -684,6 +684,10 @@ With a numeric prefix argument N, sort the Nth column.
 If the numeric prefix is -1, restore order the list was
 originally displayed in."
   (interactive "P")
+  (when (and n
+             (or (>= n (length tabulated-list-format))
+                 (< n -1)))
+    (user-error "Invalid column number"))
   (if (equal n -1)
       ;; Restore original order.
       (progn