From: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Fri, 22 Jul 2022 00:01:36 +0000 (-0400)
Subject: * lisp/help-mode.el (help-news): Use `view-file`
X-Git-Tag: emacs-29.0.90~1447^2~811
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=46e07d0a4bdb19b0aed26917227d7846bdb0f43c;p=emacs.git

* lisp/help-mode.el (help-news): Use `view-file`
---

diff --git a/lisp/help-mode.el b/lisp/help-mode.el
index e374f8e94de..d8d76114f58 100644
--- a/lisp/help-mode.el
+++ b/lisp/help-mode.el
@@ -384,8 +384,8 @@ The format is (FUNCTION ARGS...).")
   'help-function
   (lambda (file pos)
     (if help-window-keep-selected
-        (view-buffer (find-file-noselect file))
-      (view-buffer-other-window (find-file-noselect file)))
+        (view-file file)
+      (view-file-other-window file))
     (goto-char pos))
   'help-echo (purecopy "mouse-2, RET: show corresponding NEWS announcement"))
 
@@ -408,7 +408,7 @@ Commands:
 \\{help-mode-map}"
   (setq-local revert-buffer-function
               #'help-mode-revert-buffer)
-  (add-hook 'context-menu-functions 'help-mode-context-menu 5 t)
+  (add-hook 'context-menu-functions #'help-mode-context-menu 5 t)
   (setq-local tool-bar-map
               help-mode-tool-bar-map)
   (setq-local help-mode--current-data nil)
@@ -761,7 +761,7 @@ See `help-make-xrefs'."
 ;; Additional functions for (re-)creating types of help buffers.
 
 ;;;###autoload
-(define-obsolete-function-alias 'help-xref-interned 'describe-symbol "25.1")
+(define-obsolete-function-alias 'help-xref-interned #'describe-symbol "25.1")
 
 
 ;; Navigation/hyperlinking with xrefs
@@ -831,7 +831,7 @@ The help buffers are divided into \"pages\" by the ^L character."
 
 (defun help-goto-previous-page ()
   "Go to the previous page (if any) in the current buffer.
-(If not at the start of a page, go to the start of the current page.)
+\(If not at the start of a page, go to the start of the current page.)
 
 The help buffers are divided into \"pages\" by the ^L character."
   (interactive nil help-mode)