From: Lars Ingebrigtsen <larsi@gnus.org>
Date: Wed, 8 Sep 2021 10:21:12 +0000 (+0200)
Subject: Don't ding at the user in pop-mark
X-Git-Tag: emacs-28.0.90~1100
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=439ca062c830a7f3288a2dac48457edf5b1bfc59;p=emacs.git

Don't ding at the user in pop-mark

* lisp/simple.el (pop-mark): Don't ding at the user if there's no
mark to pop (bug#44375).  This function is used (in some
circumstances) when the user mouse-1-clicks links (in *Help*
buffer, for instance), which will then ding at the user before
following the link.
---

diff --git a/lisp/simple.el b/lisp/simple.el
index 9e29241cc70..14e5abc87d5 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -6622,7 +6622,6 @@ Does not set point.  Does nothing if mark ring is empty."
     (setq mark-ring (nconc mark-ring (list (copy-marker (mark-marker)))))
     (set-marker (mark-marker) (car mark-ring))
     (set-marker (car mark-ring) nil)
-    (unless (mark t) (ding))
     (pop mark-ring))
   (deactivate-mark))