From: Richard Sent <richard@freakingpenguin.com>
Date: Mon, 27 May 2024 15:32:00 +0000 (-0400)
Subject: Make 'clone-indirect-buffer-other-window' use other window
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=4340714c2402632030c08c86f786fbf213c6c906;p=emacs.git

Make 'clone-indirect-buffer-other-window' use other window

Previously, depending on the settings in 'display-buffer-alist',
'clone-indirect-buffer-other-window' would display the cloned
buffer in the original window, behaving identically to
'clone-indirect-buffer' with a non-nil display-flag.  This
behavior was inconsistent with other-window commands which
always used another window.
Now, 'clone-indirect-buffer-other-window' uses
'switch-to-buffer-other-window'.  This means it uses the same
logic as other-window commands like 'find-file-other-window'
and 'info-other-window'.
display-flag was kept for API stability and functional
compatibility reasons.
* lisp/simple.el: (clone-indirect-buffer-other-window): Use
switch-to-buffer-other-window.  (Bug#70819)

(cherry picked from commit 579aaa1ec24b0bd139053919cc87b493773248ce)
---

diff --git a/lisp/simple.el b/lisp/simple.el
index 9c2e02ccf56..667ee74d558 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -10594,8 +10594,10 @@ Returns the newly created indirect buffer."
      (list (if current-prefix-arg
 	       (read-buffer "Name of indirect buffer: " (current-buffer)))
 	   t)))
-  (let ((pop-up-windows t))
-    (clone-indirect-buffer newname display-flag norecord)))
+  ;; For compatibility, don't display the buffer if display-flag is nil.
+  (let ((buffer (clone-indirect-buffer newname nil norecord)))
+    (when display-flag
+      (switch-to-buffer-other-window buffer norecord))))
 
 
 ;;; Handling of Backspace and Delete keys.