From: Chong Yidong Date: Tue, 5 Apr 2011 21:19:42 +0000 (-0400) Subject: Remove extraneous messages in 2011-03-30 completion change. X-Git-Tag: emacs-pretest-24.0.90~104^2~275^2~406 X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=41ea9e48373c689eae6a72684a4d26d5ccd41af0;p=emacs.git Remove extraneous messages in 2011-03-30 completion change. These blocked the minibuffer contents when completing in the minibuffer, in a departure from previous Emacs behavior. * lisp/minibuffer.el (completion-in-region--postch) (completion-in-region-mode): Remove unnecessary messages. --- diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 76a9923e7a0..e98451a6909 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,8 @@ +2011-04-05 Chong Yidong + + * minibuffer.el (completion-in-region--postch) + (completion-in-region-mode): Remove unnecessary messages. + 2011-04-05 Juanma Barranquero * font-lock.el (font-lock-refresh-defaults): diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index 83358ba2f01..19084aad5d6 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -1278,7 +1278,6 @@ Point needs to be somewhere between START and END." ;; - pcomplete: pop it down on SPC or after some time-delay. ;; - semantic: use a post-command-hook check similar to this one. (defun completion-in-region--postch () - (message "completion-in-region--postch: cmd=%s" this-command) (or unread-command-events ;Don't pop down the completions in the middle of ;mouse-drag-region/mouse-set-point. (and completion-in-region--data @@ -1310,10 +1309,8 @@ Point needs to be somewhere between START and END." (delq (assq 'completion-in-region-mode minor-mode-overriding-map-alist) minor-mode-overriding-map-alist)) (if (null completion-in-region-mode) - (progn - (unless (equal "*Completions*" (buffer-name (window-buffer))) - (minibuffer-hide-completions)) - (message "Leaving completion-in-region-mode")) + (unless (equal "*Completions*" (buffer-name (window-buffer))) + (minibuffer-hide-completions)) ;; (add-hook 'pre-command-hook #'completion-in-region--prech) (add-hook 'post-command-hook #'completion-in-region--postch) (push `(completion-in-region-mode . ,completion-in-region-mode-map)