From: Lars Ingebrigtsen <larsi@gnus.org>
Date: Wed, 12 May 2021 15:36:24 +0000 (+0200)
Subject: Fix `uniquify-managed' unbounded growth
X-Git-Tag: emacs-28.0.90~2500
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=417d53db2bcafeab54b37c59667f8dee63ffd0fb;p=emacs.git

Fix `uniquify-managed' unbounded growth

* lisp/uniquify.el (uniquify-rationalize-file-buffer-names):
Protect against exponential `uniquify-managed' growth when
reverting several (more than two) buffers that have the same file
name (bug#36877).
---

diff --git a/lisp/uniquify.el b/lisp/uniquify.el
index 7cc01687f49..ffb5ecc9024 100644
--- a/lisp/uniquify.el
+++ b/lisp/uniquify.el
@@ -246,7 +246,14 @@ this rationalization."
                              (if (buffer-live-p (uniquify-item-buffer item))
                                  item))
                            items)))
-	  (setq fix-list (append fix-list items))))
+          ;; Other buffer's `uniquify-managed' lists may share
+          ;; elements.  Ensure that we don't add these elements more
+          ;; than once to this buffer's `uniquify-managed' list.
+          (let ((new-items nil))
+            (dolist (item items)
+              (unless (memq item fix-list)
+                (push item new-items)))
+	    (setq fix-list (append fix-list new-items)))))
       ;; selects buffers whose names may need changing, and others that
       ;; may conflict, then bring conflicting names together
       (uniquify-rationalize fix-list))))