From: Eli Zaretskii <eliz@gnu.org>
Date: Tue, 7 Aug 2018 14:28:35 +0000 (+0300)
Subject: Avoid segfaults in jason-serialize on MS-Windows
X-Git-Tag: emacs-27.0.90~4631
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=3eac378c966cd5c7fa9c62f2abcb8a9744dea69b;p=emacs.git

Avoid segfaults in jason-serialize on MS-Windows

* src/json.c (Fjson_serialize): Free the string with
'json_free', not 'free', since it was allocated with
'json_malloc'.  (Bug#32381)
---

diff --git a/src/json.c b/src/json.c
index afdd9a25481..540aa630c59 100644
--- a/src/json.c
+++ b/src/json.c
@@ -159,7 +159,12 @@ init_json_functions (void)
    than PTRDIFF_MAX.  Such objects wouldn't play well with the rest of
    Emacs's codebase, which generally uses ptrdiff_t for sizes and
    indices.  The other functions in this file also generally assume
-   that size_t values never exceed PTRDIFF_MAX.  */
+   that size_t values never exceed PTRDIFF_MAX.
+
+   In addition, we need to use a custom allocator because on
+   MS-Windows we replace malloc/free with our own functions, see
+   w32heap.c, so we must force the library to use our allocator, or
+   else we won't be able to free storage allocated by the library.  */
 
 static void *
 json_malloc (size_t size)
@@ -605,7 +610,7 @@ usage: (json-serialize OBJECT &rest ARGS)  */)
   char *string = json_dumps (json, JSON_COMPACT);
   if (string == NULL)
     json_out_of_memory ();
-  record_unwind_protect_ptr (free, string);
+  record_unwind_protect_ptr (json_free, string);
 
   return unbind_to (count, json_build_string (string));
 }