From: Paul Eggert <eggert@cs.ucla.edu>
Date: Thu, 3 Nov 2022 18:09:53 +0000 (-0700)
Subject: Improve suppression of bogus macOS warnings
X-Git-Tag: emacs-29.0.90~1616^2~330
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=39f5696921c1618f46358a5c189244d3993a1fca;p=emacs.git

Improve suppression of bogus macOS warnings

* configure.ac: On macOS, always use -Wno-deprecated-declarations,
as the false alarms appear even if --disable-gcc-warnings is given
(Bug#58966).
---

diff --git a/configure.ac b/configure.ac
index c9d1eb57092..b656dba4d99 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1144,12 +1144,6 @@ AS_IF([test $gl_gcc_warnings = no],
     gl_WARN_ADD([-Wno-int-in-bool-context])
   fi
 
-  # Suppress deprecation warnings from using sprintf variants,
-  # starting with Xcode 14.1 on macOS 13.
-  if test $opsys = darwin; then
-    gl_WARN_ADD([-Wno-deprecated-declarations])
-  fi
-
   # This causes too much noise in the MinGW build
   if test $opsys = mingw32; then
     gl_WARN_ADD([-Wno-pointer-sign])
@@ -1176,6 +1170,13 @@ if test "$emacs_cv_clang" = yes; then
   gl_WARN_ADD([-Wno-tautological-constant-out-of-range-compare])
 fi
 
+# Suppress deprecation warnings from using sprintf variants,
+# starting with Xcode 14.1 on macOS 13.
+# These warnings are false alarms, as Emacs usage of sprintf is safe.
+if test $opsys = darwin; then
+  gl_WARN_ADD([-Wno-deprecated-declarations])
+fi
+
 # Use a slightly smaller set of warning options for lib/.
 nw=
 nw="$nw -Wunused-macros"