From: Eshel Yaron <me@eshelyaron.com>
Date: Wed, 21 Aug 2024 16:46:05 +0000 (+0200)
Subject: ; Fix datetime formatting for '--since-time' argument
X-Git-Tag: v0.4.0~7
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=37a7fa4cfcf6beb9f2ee195ee8f7ad6e4ad58055;p=kubed.git

; Fix datetime formatting for '--since-time' argument

* kubed-transient.el
(kubed-transient-read-date): New function.
(kubed-transient-logs-for-resource)
(kubed-transient-logs): Use it.
* kubed.el (kubed-logs): Correct typo.

See https://github.com/eshelyaron/kubed/issues/5
---

diff --git a/kubed-transient.el b/kubed-transient.el
index 9b50167..ea204fc 100644
--- a/kubed-transient.el
+++ b/kubed-transient.el
@@ -15,6 +15,15 @@
 (require 'kubed)
 (require 'transient)
 
+(defun kubed-transient-read-date (prompt default _history)
+  "Prompt with PROMPT for a date, defaulting to DEFAULT.
+
+Return an RFC3339 string representation of the selected date."
+  (require 'org)
+  (when (fboundp 'org-read-date)
+    (format-time-string "%Y-%m-%dT%H:%M:%S%:z"
+                        (org-read-date 'with-time t nil prompt default))))
+
 (defun kubed-transient-read-context (prompt _initial-input _history)
   "Prompt with PROMPT for Kubernetes context."
   (kubed-read-context prompt (kubed-local-context)))
@@ -85,7 +94,7 @@ defaults to \"RESOURCEs\"."
          ("-t" "Limit lines" "--tail="
           :prompt "Byte limit: " :reader transient-read-number-N+)
          ("-S" "Since time" "--since-time="
-          :prompt "Since time: " :reader transient-read-date)]
+          :prompt "Since time: " :reader kubed-transient-read-date)]
         ["Switches"
          ("-A" "All containers" "--all-containers")
          ("-f" "Stream logs" "--follow")
@@ -138,7 +147,7 @@ defaults to \"RESOURCEs\"."
     ("-t" "Limit lines" "--tail="
      :prompt "Byte limit: " :reader transient-read-number-N+)
     ("-S" "Since time" "--since-time="
-     :prompt "Since time: " :reader transient-read-date)]
+     :prompt "Since time: " :reader kubed-transient-read-date)]
    ["Switches"
     ("-A" "All containers" "--all-containers")
     ("-f" "Stream logs" "--follow")
diff --git a/kubed.el b/kubed.el
index b1560f6..6456c6e 100644
--- a/kubed.el
+++ b/kubed.el
@@ -2809,7 +2809,7 @@ argument, also prompt for CONTEXT."
             (when follow '("--follow"))
             (when prefix '("--prefix"))
             (when timestamps '("--timestamps"))
-            (when since (list "--since" since))
+            (when since (list "--since-time" since))
             (when tail (list "--tail" (number-to-string tail)))
             (when limit (list "--limit-bytes" (number-to-string limit)))))
     (display-buffer buf)))