From: Noam Postavsky <npostavs@gmail.com>
Date: Sat, 22 Jul 2017 12:07:37 +0000 (-0400)
Subject: Revert "Let delete-selection-mode work with popup-menu commands (Bug#27569)"
X-Git-Tag: emacs-26.0.90~518^2~24
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=37954f39168e0dbfe3a82feb9b58fecfc5f1f318;p=emacs.git

Revert "Let delete-selection-mode work with popup-menu commands (Bug#27569)"

It turns out that this change is not needed, and it leaves several
command loops settings not done.

https://lists.gnu.org/archive/html/emacs-devel/2017-07/msg00757.html
https://lists.gnu.org/archive/html/emacs-devel/2017-07/msg00840.html
---

diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el
index 4a569783293..3ca7d1b5b3d 100644
--- a/lisp/menu-bar.el
+++ b/lisp/menu-bar.el
@@ -2375,10 +2375,6 @@ FROM-MENU-BAR, if non-nil, means we are dropping one of menu-bar's menus."
       ;; `setup-specified-language-environment', for instance,
       ;; expects this to be set from a menu keymap.
       (setq last-command-event (car (last event)))
-      ;; Update `this-command' and run `pre-command-hook' so that
-      ;; things like `delete-selection-pre-hook' will work correctly.
-      (setq this-command cmd)
-      (run-hooks 'pre-command-hook)
       ;; mouse-major-mode-menu was using `command-execute' instead.
       (call-interactively cmd))))