From: Miles Bader <miles@gnu.org>
Date: Thu, 5 Oct 2000 05:21:13 +0000 (+0000)
Subject: (image_ascent): Rearrange ascent calculation for the has-a-font case.
X-Git-Tag: emacs-pretest-21.0.90~1147
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=3694cb3fdecea0dda1b72429df36f1a6eef197d1;p=emacs.git

(image_ascent): Rearrange ascent calculation for the has-a-font case.
---

diff --git a/src/xfns.c b/src/xfns.c
index 457ceb202c7..370ce8825d7 100644
--- a/src/xfns.c
+++ b/src/xfns.c
@@ -5526,7 +5526,12 @@ image_ascent (img, face)
   if (img->ascent == CENTERED_IMAGE_ASCENT)
     {
       if (face->font)
-	ascent = height / 2 - (face->font->descent - face->font->ascent) / 2;
+	/* This expression is arranged so that if the image can't be
+	   exactly centered, it will be moved slightly up.  This is
+	   because a typical font is `top-heavy' (due to the presence
+	   uppercase letters), so the image placement should err towards
+	   being top-heavy too.  It also just generally looks better.  */
+	ascent = (height + face->font->ascent - face->font->descent + 1) / 2;
       else
 	ascent = height / 2;
     }