From: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Thu, 15 May 2003 21:21:06 +0000 (+0000)
Subject: (apply_modifiers): Don't fill the other cache.
X-Git-Tag: ttn-vms-21-2-B4~10145
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=35fb885d5c6cf272c7744ebda8d83330ebc80a4d;p=emacs.git

(apply_modifiers): Don't fill the other cache.
---

diff --git a/src/ChangeLog b/src/ChangeLog
index 702ed09afee..1ff5c7cedf4 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,7 @@
+2003-05-15  Stefan Monnier  <monnier@cs.yale.edu>
+
+	* keyboard.c (apply_modifiers): Don't fill the other cache.
+
 2003-05-14  Stefan Monnier  <monnier@cs.yale.edu>
 
 	* .gdbinit-union: New file, for USE_LISP_UNION_TYPE users.
diff --git a/src/keyboard.c b/src/keyboard.c
index 512755faf28..dd8b751c8d5 100644
--- a/src/keyboard.c
+++ b/src/keyboard.c
@@ -6091,12 +6091,15 @@ apply_modifiers (modifiers, base)
       entry = Fcons (index, new_symbol);
       Fput (base, Qmodifier_cache, Fcons (entry, cache));
 
-      /* We have the parsing info now for free, so add it to the caches.  */
-      XSETFASTINT (index, modifiers);
-      Fput (new_symbol, Qevent_symbol_element_mask,
-	    Fcons (base, Fcons (index, Qnil)));
-      Fput (new_symbol, Qevent_symbol_elements,
-	    Fcons (base, lispy_modifier_list (modifiers)));
+      /* We have the parsing info now for free, so we could add it to
+	 the caches:
+         XSETFASTINT (index, modifiers);
+         Fput (new_symbol, Qevent_symbol_element_mask,
+               Fcons (base, Fcons (index, Qnil)));
+         Fput (new_symbol, Qevent_symbol_elements,
+               Fcons (base, lispy_modifier_list (modifiers)));
+	 Sadly, this is only correct if `base' is indeed a base event,
+	 which is not necessarily the case.  -stef  */
     }
 
   /* Make sure this symbol is of the same kind as BASE.