From: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Tue, 8 Jan 2019 16:28:00 +0000 (-0500)
Subject: * lisp/help-fns.el (help--load-prefixes): Demote errors from files.
X-Git-Tag: emacs-27.0.90~3846
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=35224ac3aebd4c55a4cdccea908a62f92aaebf25;p=emacs.git

* lisp/help-fns.el (help--load-prefixes): Demote errors from files.
---

diff --git a/lisp/help-fns.el b/lisp/help-fns.el
index 04bb31485d6..b4e93d36d4c 100644
--- a/lisp/help-fns.el
+++ b/lisp/help-fns.el
@@ -68,6 +68,9 @@ The functions will receive the function name as argument.")
 
 (defun help--loaded-p (file)
   "Try and figure out if FILE has already been loaded."
+  ;; FIXME: this regexp business is not good enough: for file
+  ;; `toto', it will say `toto' is loaded when in reality it was
+  ;; just cedet/semantic/toto that has been loaded.
   (or (let ((feature (intern-soft file)))
         (and feature (featurep feature)))
       (let* ((re (load-history-regexp file))
@@ -83,11 +86,9 @@ The functions will receive the function name as argument.")
     (dolist (file files)
       ;; FIXME: Should we scan help-definition-prefixes to remove
       ;; other prefixes of the same file?
-      ;; FIXME: this regexp business is not good enough: for file
-      ;; `toto', it will say `toto' is loaded when in reality it was
-      ;; just cedet/semantic/toto that has been loaded.
       (unless (help--loaded-p file)
-        (load file 'noerror 'nomessage)))))
+        (with-demoted-errors "while loading: %S"
+          (load file 'noerror 'nomessage))))))
 
 (defun help--symbol-completion-table (string pred action)
   (let ((prefixes (radix-tree-prefixes (help-definition-prefixes) string)))