From: Juri Linkov <juri@jurta.org>
Date: Sun, 11 Nov 2007 22:24:04 +0000 (+0000)
Subject: Add comments about isearch support.
X-Git-Tag: emacs-pretest-23.0.90~9779
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=34065e5efde6d85307aa2fde77b1af0d059635b3;p=emacs.git

Add comments about isearch support.
---

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 65962613866..e0f5448e42f 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,7 @@
+2007-11-11  Tassilo Horn  <tassilo@member.fsf.org>
+
+	* doc-view.el: Add comments about isearch support.
+
 2007-11-11  Dan Nicolaescu  <dann@ics.uci.edu>
 
 	* vc.el (vc-start-entry): Fix setting the in the case the function
diff --git a/lisp/doc-view.el b/lisp/doc-view.el
index 89f1b009f7f..c07f5b5967a 100644
--- a/lisp/doc-view.el
+++ b/lisp/doc-view.el
@@ -97,9 +97,8 @@
 ;;
 ;; and modify them to your needs.
 
-;;; Code:
+;;; Todo:
 
-;; Todo:
 ;; - better menu.
 ;; - don't use `find-file'.
 ;; - Bind slicing to a drag event.
@@ -107,6 +106,31 @@
 ;; - get rid of the silly arrow in the fringe.
 ;; - improve anti-aliasing (pdf-utils gets it better).
 
+;;;; About isearch support
+
+;; I tried implementing isearch by setting
+;; `isearch-search-fun-function' buffer-locally, but that didn't
+;; work too good.  The function doing the real search was called
+;; endlessly somehow.  But even if we'd get that working no real
+;; isearch feeling comes up due to the missing match highlighting.
+;; Currently I display all lines containing a match in a tooltip and
+;; each C-s or C-r jumps directly to the next/previous page with a
+;; match.  With isearch we could only display the current match.  So
+;; we had to decide if another C-s jumps to the next page with a
+;; match (thus only the first match in a page will be displayed in a
+;; tooltip) or to the next match, which would do nothing visible
+;; (except the tooltip) if the next match is on the same page.
+
+;; And it's much slower than the current search facility, because
+;; isearch really searches for each step forward or backward wheras
+;; the current approach searches once and then it knows to which
+;; pages to jump.
+
+;; Anyway, if someone with better isearch knowledge wants to give it a try,
+;; feel free to do it.  --Tassilo
+
+;;; Code:
+
 (require 'dired)
 (require 'image-mode)
 (require 'jka-compr)