From: Jan Djärv <jan.h.d@swipnet.se>
Date: Wed, 1 Oct 2014 18:10:21 +0000 (+0200)
Subject: * xfaces.c (Finternal_set_lisp_face_attribute): Added FIXME comment.
X-Git-Tag: emacs-24.3.94~5
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=335e9627ca78f7be9eea27f38a530fd51a1e6995;p=emacs.git

* xfaces.c (Finternal_set_lisp_face_attribute): Added FIXME comment.
---

diff --git a/src/ChangeLog b/src/ChangeLog
index 63fcf130542..31320ed533f 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -2,6 +2,7 @@
 
 	* xfaces.c (Finternal_set_lisp_face_attribute): Don't try to
 	make a font_object from a tty frame (Bug#18573).
+	(Finternal_set_lisp_face_attribute): Added FIXME comment.
 
 2014-09-30  Eli Zaretskii  <eliz@gnu.org>
 
diff --git a/src/xfaces.c b/src/xfaces.c
index 5d158f08099..9579bcce572 100644
--- a/src/xfaces.c
+++ b/src/xfaces.c
@@ -3119,6 +3119,13 @@ FRAME 0 means change the face on all frames, and change the default
 		f = XFRAME (selected_frame);
 	      else
 		f = XFRAME (frame);
+
+              /* FIXME:
+                 If frame is t, and selected frame is a tty frame, the font
+                 can't be realized.  An improvement wuld be to loop over frames
+                 for a non-tty frame and use that.  See discussion in
+                 bug#18573.
+              */
               if (f->terminal->type != output_termcap)
                 {
                   if (! FONT_OBJECT_P (value))