From: Lars Ingebrigtsen <larsi@gnus.org>
Date: Sun, 14 Feb 2021 15:51:14 +0000 (+0100)
Subject: Don't update `minor-modes' in global modes
X-Git-Tag: emacs-28.0.90~3738
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=2f00a3435a05bbcedbf8851baeefd33463bc525b;p=emacs.git

Don't update `minor-modes' in global modes

* lisp/emacs-lisp/easy-mmode.el (define-minor-mode): There's no
point in setting the buffer-local `minor-modes' in global modes.
---

diff --git a/lisp/emacs-lisp/easy-mmode.el b/lisp/emacs-lisp/easy-mmode.el
index 7e5e2a9b8a9..5ba0d2187f2 100644
--- a/lisp/emacs-lisp/easy-mmode.el
+++ b/lisp/emacs-lisp/easy-mmode.el
@@ -330,10 +330,11 @@ or call the function `%s'."))))
                    nil)
                   (t
                    t)))
-           ;; Keep `minor-modes' up to date.
-           (setq minor-modes (delq ',modefun minor-modes))
-           (when ,getter
-             (push ',modefun minor-modes))
+           (unless ,globalp
+             ;; Keep `minor-modes' up to date.
+             (setq minor-modes (delq ',modefun minor-modes))
+             (when ,getter
+               (push ',modefun minor-modes)))
            ,@body
            ;; The on/off hooks are here for backward compatibility only.
            (run-hooks ',hook (if ,getter ',hook-on ',hook-off))