From: Lars Ingebrigtsen <larsi@gnus.org>
Date: Thu, 3 Jun 2021 07:50:20 +0000 (+0200)
Subject: Fix problem with empty command histories in eshell and `erase'
X-Git-Tag: emacs-28.0.90~2213
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=2e8212a56548d0de74c2f3c3abe72222368ae0c6;p=emacs.git

Fix problem with empty command histories in eshell and `erase'

* lisp/eshell/em-hist.el (eshell-add-input-to-history): Protect
against an empty ring (bug#48770).
---

diff --git a/lisp/eshell/em-hist.el b/lisp/eshell/em-hist.el
index e559f5b39fe..18e19a9d9a5 100644
--- a/lisp/eshell/em-hist.el
+++ b/lisp/eshell/em-hist.el
@@ -379,7 +379,7 @@ input."
              (if (eq eshell-hist-ignoredups 'erase)
                  ;; Remove any old occurrences of the input, and put
                  ;; the new one at the end.
-                 (progn
+                 (unless (ring-empty-p eshell-history-ring)
                    (ring-remove eshell-history-ring
 	                        (ring-member eshell-history-ring input))
                    t)